router: remove implicit cast of lambda to bool#7930
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Aug 15, 2019
Merged
router: remove implicit cast of lambda to bool#7930mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Per envoyproxy#7736, we're inadvertently casting a lambda expression to bool. Fortunately, the code is attempting to pass true, so it works. Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a Fixes: envoyproxy#7736 Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
zuercher
changed the title
zuercher
changed the title
yanavlasov
approved these changes
Aug 15, 2019
lizan
approved these changes
Aug 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #7736, we're inadvertently casting a lambda expression to
bool. Fortunately, the code is attempting to pass true, so it
works.
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Fixes: #7736
Signed-off-by: Stephan Zuercher zuercher@gmail.com